[primer] Switch from JSONReporter to JSON2Reporter#10949
[primer] Switch from JSONReporter to JSON2Reporter#10949Pierre-Sassoulas merged 2 commits intomainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Constructor now takes pre-loaded PackageMessages dicts, making it directly testable with in-memory data. I/O and batch merging move to a from_json() factory method; _load_json() becomes module-level.
5a6e813 to
c028b74
Compare
This comment has been minimized.
This comment has been minimized.
The old JSONReporter is deprecated; use JSON2Reporter which provides confidence, absolutePath, and camelCase messageId fields. Update all primer test fixtures accordingly.
b015b7b to
7943b25
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #10949 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 178 178
Lines 19637 19642 +5
=======================================
+ Hits 18885 18890 +5
Misses 752 752
🚀 New features to boost your workflow:
|
|
Haven't looked at this yet, the primer comment looks worrying. Is this working as expected Pierre? |
|
The |
|
Thank you for the review ! Next MR is finally time to make the primer pretty and see all the little primers examples change for the better 😄 |
Type of Changes
Description
JSON2Reporter provides confidence, and absolutePath. Update all primer test fixtures accordingly and add a test case.